Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xiaomi Mi 5 #456

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Add support for Xiaomi Mi 5 #456

merged 4 commits into from
Nov 30, 2024

Conversation

sib0ndt
Copy link
Contributor

@sib0ndt sib0ndt commented Nov 27, 2024

Add support for Xiaomi Mi 5 (gemini)

@sib0ndt sib0ndt changed the title Xiaomi Mi 5 Add support for Xiaomi Mi 5 Nov 27, 2024
/ {
qcom,msm-id = <QCOM_ID_MSM8996 0x30001>;
qcom,board-id = <31 0>, <32 0>;
qcom,pmic-id = <0x20009 0x2000a 0x00 0x00>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does pmic-id necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could boot with out it but nvm it was already merged

@TravMurav TravMurav merged commit 93d6d65 into msm8916-mainline:main Nov 30, 2024
42 checks passed
@TravMurav
Copy link
Member

Thanks! I've manually squashed commits and reworded the subject. I'd appreciate changes like this to be a single commit with correct subject next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants